[FFmpeg-cvslog] r22288 - trunk/libavcodec/avcodec.h

[Michael Niedermayer]

On Sun, Mar 07, 2010 at 10:16:44PM +0100, alexc wrote:
> Author: alexc
> Date: Sun Mar  7 22:16:44 2010
> New Revision: 22288
> 
> Log:
> Increase FF_INPUT_BUFFER_PADDING_SIZE to 64.
> 
> The purpose of this is to give decoders a reasonable amount of buffer to work
> with before needing to check for overreads.

breaks ABI, and is wrong, as the padding needed by some codecs for fast
overread detection is too much for small frame codecs like *celp ...

IMHO
1. revert this
2. replace all memset(FF_INPUT_BUFFER_PADDING_SIZE) by AV_ZERO32()
3. add a field to AVCodec that specifies the required padding for each decoder
4. replace all alloc(FF_INPUT_BUFFER_PADDING_SIZE) by that field from 3.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100309/6f6c9112/attachment.pgp>