[FFmpeg-cvslog] r22313 - trunk/configure

[Alexander Strange]

On Mar 7, 2010, at 9:36 PM, mru wrote:

> Author: mru
> Date: Mon Mar  8 03:36:27 2010
> New Revision: 22313
> 
> Log:
> Error on missing function prototypes with gcc
> 
> This makes it an error to not have a prototype in scope for
> a function with external linkage.  The flag is only enabled
> for gcc due to -Werror=type not working with all compilers.

This broke --enable-pthreads:
> make libavcodec/pthread.o
CC	libavcodec/pthread.o
/Users/astrange/Projects/video/ffmpeg/libavcodec/pthread.c:49: warning: ?force_align_arg_pointer? attribute ignored
/Users/astrange/Projects/video/ffmpeg/libavcodec/pthread.c:137: error: no previous prototype for ?avcodec_thread_execute2?
make: *** [libavcodec/pthread.o] Error 1

Obvious patch attached, but does it need a minor version bump?
BTW I'm not sure these should be in a public header ideally...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-pthreads.diff
Type: application/octet-stream
Size: 810 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100308/853a2c4c/attachment.obj>
-------------- next part --------------


> Modified:
>   trunk/configure
> 
> Modified: trunk/configure
> ==============================================================================
> --- trunk/configure	Mon Mar  8 03:36:22 2010	(r22312)
> +++ trunk/configure	Mon Mar  8 03:36:27 2010	(r22313)
> @@ -2752,6 +2752,7 @@ elif enabled ccc; then
> elif enabled gcc; then
>     check_cflags -fno-tree-vectorize
>     check_cflags -Werror=implicit
> +    check_cflags -Werror=missing-prototypes
> elif enabled clang; then
>     check_cflags -Qunused-arguments
> elif enabled armcc; then
> _______________________________________________
> ffmpeg-cvslog mailing list
> ffmpeg-cvslog at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-cvslog