[FFmpeg-cvslog] r22166 - trunk/libavformat/bink.c

Reimar Döffinger Reimar.Doeffinger
Wed Mar 3 19:26:26 CET 2010


>              /* get one audio packet per track */
>              if ((ret = av_get_packet(pb, pkt, audio_size))
>                                             != audio_size)
>                  return ret;

This looks strange, does this return partial audio packets but without
setting their stream_index and pts values??
This is related to this patch insofar as the usual
if (ret < 0) return ret;
is not good enough after this changes, since for ret == 0

> +            bink->audio_pts[bink->current_track -1] +=
> +                AV_RL32(pkt->data) / (2 * s->streams[bink->current_track]->codec->channels);

This would crash (and for values < 4 it relies on padding already now.



More information about the ffmpeg-cvslog mailing list