[FFmpeg-cvslog] r23904 - in trunk: cmdutils.h libavcodec/aac_parser.h libavcodec/ac3.c libavcodec/ac3.h libavcodec/ac3_parser.h libavcodec/ac3tab.c libavcodec/allcodecs.c libavcodec/alsdec.c libavcodec/avcodec.h l...

[Baptiste Coudurier]

On 06/30/2010 10:41 AM, Michael Niedermayer wrote:
> On Wed, Jun 30, 2010 at 05:38:06PM +0200, mru wrote:
>> Author: mru
>> Date: Wed Jun 30 17:38:06 2010
>> New Revision: 23904
> [...]
>>   /**
>> - * Sets the libav* libraries log level.
>> + * Set the libav* libraries log level.
>>    */
>>   int opt_loglevel(const char *opt, const char *arg);
>>
>
> The 3rd vs. 1st person style has been discussed many times and never
> has a majority for this change existed let alone a consensus. Besides
> you do not maintain these files that you change and 3rd person is
> the recommanded style of javadoc&  doxygen. And it also sounds much
> better (to me at least).

It seems commits continued despite the controversial commit and the 
reactions from other developpers.
IIRC Jason's svn account was killed for a better commit.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org