[FFmpeg-cvslog] r23815 - in trunk/libavcodec: vp8dsp.c vp8dsp.h x86/Makefile x86/vp8dsp-init.c x86/vp8dsp.asm

[Stefano Sabatini]

On date Sunday 2010-06-27 23:47:11 +0100, M?ns Rullg?rd wrote:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> 
> > On date Sunday 2010-06-27 04:01:45 +0200, rbultje wrote:
> >> Author: rbultje
> >> Date: Sun Jun 27 04:01:45 2010
> >> New Revision: 23815
> >> 
> >> Log:
> >> First shot at VP8 optimizations:
> >> - MMXEXT, SSE2 and SSSE3 MC functions
> >> - MMX and SSE4 IDCT dc_add functions
> >> 
> >> Patch by Jason Garrett-Glaser <darkshikari gmail com> and myself.
> >> 
> >> Added:
> >>    trunk/libavcodec/x86/vp8dsp-init.c
> >>    trunk/libavcodec/x86/vp8dsp.asm
> >> Modified:
> >>    trunk/libavcodec/vp8dsp.c
> >>    trunk/libavcodec/vp8dsp.h
> >>    trunk/libavcodec/x86/Makefile
> >> 
> >> Modified: trunk/libavcodec/vp8dsp.c
> >> ==============================================================================
> >> --- trunk/libavcodec/vp8dsp.c	Sun Jun 27 03:46:34 2010	(r23814)
> >> +++ trunk/libavcodec/vp8dsp.c	Sun Jun 27 04:01:45 2010	(r23815)
> >> @@ -451,4 +451,7 @@ av_cold void ff_vp8dsp_init(VP8DSPContex
> >>      VP8_BILINEAR_MC_FUNC(0, 16);
> >>      VP8_BILINEAR_MC_FUNC(1, 8);
> >>      VP8_BILINEAR_MC_FUNC(2, 4);
> >> +
> >> +    if (ARCH_X86)
> >> +        ff_vp8dsp_init_x86(dsp);
> >>  }
> >
> > This breaks linking if optimizations are disabled:

That's not accurate, this fails if --disable-mmx.

> Don't do that then.  There is code like this everywhere.

That's the only point where it currently fails (togheter with the
vp8dsp code I pointed out in another post). My local hack for this is:

    if (ARCH_X86 && HAVE_MMX)
        ff_vp8dsp_init_x86(dsp);