[FFmpeg-cvslog] r23647 - in trunk: Changelog libavcodec/Makefile libavcodec/aacdec.c libavcodec/aacsbr.c libavcodec/avcodec.h libavcodec/mpeg4audio.c libavcodec/ps.c libavcodec/ps.h libavcodec/ps_tablegen.c libavc...

[Alex Converse]

On Sun, Jun 20, 2010 at 9:10 AM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Sun, Jun 20, 2010 at 02:53:36PM +0200, Reimar D?ffinger wrote:
>> On Sun, Jun 20, 2010 at 02:39:28PM +0200, Michael Niedermayer wrote:
>> > On Sun, Jun 20, 2010 at 08:27:17AM +0200, Reimar D?ffinger wrote:
>> > > On Sun, Jun 20, 2010 at 04:06:06AM +0200, Michael Niedermayer wrote:
>> > > > > +#if CONFIG_HARDCODED_TABLES
>> > > > > +#define ps_tableinit()
>> > > > > +#include "libavcodec/ps_tables.h"
>> > > > > +#else
>> > > > > +#include "../libavutil/common.h"
>> > > > > +#ifndef M_SQRT1_2
>> > > > > +#define M_SQRT1_2 ? ? ?0.70710678118654752440 ?/* 1/sqrt(2) */
>> > > > > +#endif
>> > > > > +#ifndef M_PI
>> > > > > +#define M_PI ? ? ? ? ? 3.14159265358979323846 ?/* pi */
>> > > > > +#endif
>> > > > > +#ifndef M_SQRT2
>> > > > > +#define M_SQRT2 ? ? ? ?1.41421356237309504880 ?/* sqrt(2) */
>> > > >
>> > > > these constants should be already in some libavutil header
>> > >
>> > > Yes, but that header can't be used for host compilation.
>> >
>> > why not?
>>
>> Sorry! That was based on outdated information.
>> Yes, mathematics.h should be safe to use, so it should be used...
>
> Separate header or not, I can suggest patch below...
>

PS parts LGTM