[FFmpeg-cvslog] r18312 - trunk/configure

[Måns Rullgård]

Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:

> On Mon, 2010-05-31 at 23:59 +0100, M?ns Rullg?rd wrote:
>> Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
>> 
>> > On Thu, 2009-04-02 at 10:49 +0200, gb wrote:
>> >> Author: gb
>> >> Date: Thu Apr  2 10:49:33 2009
>> >> New Revision: 18312
>> >> 
>> >> Log:
>> >> Add VA API deps.
>> >
>> >>  check_lib math.h sin -lm
>> >> +check_lib va/va.h vaInitialize -lva
>> >
>> > This adds a bogus dependency on libva even if vaapi support is disabled.
>> 
>> We link with --as-needed, so no there is no problem.
>
> There is a problem at least for creating static libraries.

Static libraries don't have dependencies, so there can be no problem
there.

> "-lva" is added to the list of flags that the _application_ must use
> when linking with the library.

What list?

> So any application would need to link with --as-needed too; and even
> if they did there would still be problems like the link failing if
> libva was removed from the system between creating the FFmpeg static
> libraries and linking the application. I think that adding
> completely irrelevant libraries and relying on --as-needed to remove
> them is not a good idea for the FFmpeg binaries either when it would
> be easy to avoid.

Just like listening to you is not a good idea when it would be easy to
avoid.

-- 
M?ns Rullg?rd
mans at mansr.com