[FFmpeg-cvslog] r24443 - trunk/libavcodec/vp8.c

[Michael Niedermayer]

On Fri, Jul 23, 2010 at 04:37:43PM -0400, compn wrote:
> On Fri, 23 Jul 2010 20:36:43 +0200, Reimar D?ffinger wrote:
> >On Fri, Jul 23, 2010 at 11:23:50AM -0700, Jason Garrett-Glaser wrote:
> >> On Fri, Jul 23, 2010 at 9:27 AM, Reimar D?ffinger
> >> <Reimar.Doeffinger at gmx.de> wrote:
> >> > And yes, learning things is one of the main reasons for me to follow this project,
> >> > and your style of committing is close to making understanding and learning from
> >> > your changes a waste of time for me.
> >> 
> >> I'm sorry that you're too incompetent to read diffs and commit
> >> messages.  Again, feel free to lobby for the removal of my commit
> >> access.  In the meantime, I will continue to do actual work.
> >
> >Thanks for your "I'm doing actual work, now shut up you worms" attitude.
> >And your commit message btw. did not give the slightest hint that all you did
> >was remove the if (I don't think it provided any really useful information
> >at all), are you seriously going to claim you can see without
> >extra tools that the reindented code was not changed?
> 
> yes, darkshikikari broke rule #7.


> yes, the commit message lacks any 'indentation' note.

this can be fixed, i suspect darkshikikari wouldnt mind if you did add a
note on "5 unchanged lines being reindented"


anyway, i think people overreact a bit and pour gasoline into the flames
instead of trying to actually improve things.
yes i agree that the commit wasnt optimal and would have been a bit more
readable if split...
but as darkshikikari feels strongly about it and its in this case here
a minor issue, that being a very simple and small change i dont think
its worth the fight. That is unless we have some other people who
feel strongly the opposite way, then i would have to try to find a solution
everyone can accept.
Is there anyone who feels strongly about this and wants me to look into
finding a different solution from just leaving the commit as is?

also we maybe could avoid things like this in the future by improving
the svnlog message generator script.
It could run 2 diffs one with and one without whitespace changes and
if and only if they differ include both, i have suggested things like
this in the past but noone seems to have had time to work on it ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100727/4f4f7ccd/attachment.pgp>