[FFmpeg-cvslog] r24445 - trunk/libavcodec/vp8.c

[Jason Garrett-Glaser]

On Sat, Jul 24, 2010 at 3:37 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> On Fri, Jul 23, 2010 at 01:04:51AM +0200, darkshikari wrote:
>> Author: darkshikari
>> Date: Fri Jul 23 01:04:51 2010
>> New Revision: 24445
>>
>> Log:
>> Shut up a GCC warning in VP8
>>
>> Modified:
>> ? ?trunk/libavcodec/vp8.c
>>
>> Modified: trunk/libavcodec/vp8.c
>> ==============================================================================
>> --- trunk/libavcodec/vp8.c ? ?Fri Jul 23 01:03:08 2010 ? ? ? ?(r24444)
>> +++ trunk/libavcodec/vp8.c ? ?Fri Jul 23 01:04:51 2010 ? ? ? ?(r24445)
>> @@ -1402,7 +1402,7 @@ static int vp8_decode_frame(AVCodecConte
>> ? ? ?VP8Context *s = avctx->priv_data;
>> ? ? ?int ret, mb_x, mb_y, i, y, referenced;
>> ? ? ?enum AVDiscard skip_thresh;
>> - ? ?AVFrame *curframe;
>> + ? ?AVFrame *curframe = NULL;
>
> Either the commit message or the patch looks wrong.
> If this is really just about shutting up gcc, you should use av_uninit()
> instead of uselessly assigning the variable.
> If this is fixing a real bug (code really reading uninitialized
> variable), then the commit message should be changed.

Oh, I didn't know av_uninit existed.  Anyone should feel free to change it.

Dark Shikari