[FFmpeg-cvslog] r24393 - in trunk: Changelog Makefile cmdutils.c common.mak configure libavcore libavcore/Makefile libavcore/avcore.h libavcore/libavcore.v libavcore/utils.c

[Stefano Sabatini]

On date Thursday 2010-07-22 22:55:35 +0200, Vitor Sessak wrote:
> On 07/22/2010 10:50 PM, M?ns Rullg?rd wrote:
>> Vitor Sessak<vitor1001 at gmail.com>  writes:
>>
>>> On 07/22/2010 09:35 PM, M?ns Rullg?rd wrote:
>>>> Vitor Sessak<vitor1001 at gmail.com>   writes:
>>>>
>>>>> On 07/22/2010 08:48 AM, M?ns Rullg?rd wrote:
>>>>>> Vitor Sessak<vitor1001 at gmail.com>    writes:
>>>>>>
>>>>>>> On 07/21/2010 08:28 PM, stefano wrote:
>>>>>>>> Author: stefano
>>>>>>>> Date: Wed Jul 21 20:28:42 2010
>>>>>>>> New Revision: 24393
>>>>>>>>
>>>>>>>> Log:
>>>>>>>> Add libavcore.
>>>>>>>>
>>>>>>>> The new library is meant to contain the core multimedia utilities for
>>>>>>>> FFmpeg, to make them shareable between more libav* libraries.
>>>>>>>>
>>>>>>>> See thread:
>>>>>>>> Subject: [FFmpeg-devel] [RFC] New library for shared non-generic libav* utils
>>>>>>>> Date: Fri, 9 Jul 2010 01:07:40 +0200
>>>>>>>>
>>>>>>>> Added:
>>>>>>>>        trunk/libavcore/
>>>>>>>>        trunk/libavcore/Makefile   (contents, props changed)
>>>>>>>>        trunk/libavcore/avcore.h
>>>>>>>>        trunk/libavcore/libavcore.v
>>>>>>>>        trunk/libavcore/utils.c
>>>>>>>> Modified:
>>>>>>>>        trunk/Changelog
>>>>>>>>        trunk/Makefile
>>>>>>>>        trunk/cmdutils.c
>>>>>>>>        trunk/common.mak
>>>>>>>>        trunk/configure
>>>>>>>
>>>>>>> Missing change to doc/APIchanges.
>>>>>>
>>>>>> I don't see any new APIs.
>>>>>
>>>>> lav* users won't need now to link against this new library?
>>>>
>>>> Not until it contains something.
>>>
>>> That's easy to fix ;)
>>>
>>> See attached patch.
>>>
>>> -Vitor
>>>
>>> Index: libavcore/amr.c
>>> ===================================================================
>>> --- libavcore/amr.c	(revision 0)
>>> +++ libavcore/amr.c	(revision 0)
>>> @@ -0,0 +1,22 @@
>>> +/*
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; either
>>> + * version 2.1 of the License, or (at your option) any later version.
>>> + *
>>> + * FFmpeg is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>> + * Lesser General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU Lesser General Public
>>> + * License along with FFmpeg; if not, write to the Free Software
>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>>> + */
>>> +
>>> +#include<stdint.h>
>>> +
>>> +const uint8_t av_amrnb_packed_size[16] =
>>> +    {12, 13, 15, 17, 19, 20, 26, 31, 5, 0, 0, 0, 0, 0, 0, 0};
>>
>> Is this some kind of sick joke?
>
> Oops, I misunderstood what libavcore was supposed to do, please ignore  
> this patch. There is still no sane place where to put code duplicated in  
> libavcodec and libavformat :p

libavcodec?

BTW for who missed the libavcore genesis discussion, it is intended to
contain *multimedia* *generic* utils which won't have place in
libavutil.

I plan to move there pixfmts, pixdescs, samplefmts, avpicture* and
imgconvert functions and some parsing utilities.

And BTW we already have an API, libavcore_get_version() and
libavcore_configuration() and the AVCORE_VERSION_* symbols.

Currently libavcore can be safely disabled with no loss in
functionality, but later it will be required by libavcodec and
libavfilter as more and more code will be moved there.

Regards.