[FFmpeg-cvslog] r24429 - trunk/libavcodec/vp8.c

[Reimar Döffinger]

On Thu, Jul 22, 2010 at 02:15:29PM +0200, darkshikari wrote:
> @@ -1496,12 +1497,10 @@ static int vp8_decode_frame(AVCodecConte
>                  AV_ZERO64(s->non_zero_count_cache[4]);  // chroma
>              }
>  
> -            if (mb->mode <= MODE_I4x4) {
> +            if (mb->mode <= MODE_I4x4)
>                  intra_predict(s, dst, mb, intra4x4_mb, mb_x, mb_y);
> -                memset(mb->bmv, 0, sizeof(mb->bmv));
> -            } else {
> +            else
>                  inter_predict(s, dst, mb, mb_x, mb_y);
> -            }

Coding style nit:
You should be using
if () {
} else

always, even if there's only one line between if and else.
I also think changing the {} stuff made it needlessly hard to
see that removing that memset was really the only thing you changed.