[FFmpeg-cvslog] r24370 - trunk/Makefile

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Wed, Jul 21, 2010 at 06:33:12PM +0200, Michael Niedermayer wrote:
>> On Wed, Jul 21, 2010 at 10:16:57AM -0300, Ramiro Polla wrote:
>> > On Wed, Jul 21, 2010 at 9:26 AM, Diego Biurrun <diego at biurrun.de> wrote:
>> > > On Tue, Jul 20, 2010 at 07:17:06PM -0300, Ramiro Polla wrote:
>> > >> 2010/7/20 M?ns Rullg?rd <mans at mansr.com>:
>> > >> > Ramiro Polla <ramiro.polla at gmail.com> writes:
>> > >> >> On Tue, Jul 20, 2010 at 3:10 PM, mru <subversion at mplayerhq.hu> wrote:
>> > >> >>>
>> > >> >>> Log:
>> > >> >>> Rerun configure when all*.c files have changed
>> > >> >>
>> > >> >> Ugh, does this mean 'make' might run 'configure' (like the autotools
>> > >> >> do)? I find that particularly annoying. Isn't it possible to give an
>> > >> >> error message instead?
>> > >> >
>> > >> > Where's the harm?
>> > >>
>> > >> Principle of least surprise? I expect configure to configure, make to
>> > >> make, and make install to install. But if I'm the only one that finds
>> > >> it annoying then don't bother, it doesn't matter that much...
>> > >
>> > > I specifically asked for this feature and I consider it essential.
>> > > Of course you have learned the hard way that configure needs to be
>> > > rerun every now and then, but I do not think this is expected behavior
>> > > for anybody else.
>> > >
>> > > To have a build fail when the sources are perfectly valid is
>> > > unacceptable, period.
>> > 
>> > Maybe I wasn't clear but I don't like make failing cryptically either.
>> > I really appreciate the Makefile detecting that configure should be
>> > re-run. My suggestion was that an error be printed such as "configure
>> > must be re-run".
>> 
>> i also would prefer if make didnt run configure but printed an error message
>> 
>> as developer i somehow prefer tools to act in a simple and predictable way
>> over tools that do everything they cannot proof to be unneeded.
>> Its easier in the first case to convince the tools to just do what is
>> actually needed and safe some time on rebuilds.
>
> Besides what command line switches are used for configure in this automatic
> rerun?

Same as last manual run.

> Whichever they are they might not be what the user wanted when he
> wanted to rerun configure next time.

That's more likely than the user wanting the build to fail.

> And (redundantly) reruning configure can lead to minor changes to
> headers that then in chain reaction cause alot more to be rebuild
> than needed

If config.h isn't changed, nothing will be needlessly rebuilt.

Until you lot decide how you want it, I'm not changing anything.

-- 
M?ns Rullg?rd
mans at mansr.com