[FFmpeg-cvslog] r24260 - in trunk/tests: fate2.mak ref/fate/msmpeg4v1

[Reimar Döffinger]

On Sat, Jul 17, 2010 at 08:39:40PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> >> And any code conditional on msmpeg4v1?  I see no point keeping that either.
> >
> > that code would be quite helpfull to someone who wanted to finish
> > the encoder and someone who wanted to do this likely would not find
> > it if its just in a distant past revission
> 
> Do you honestly think anyone will ever do that?
> 
> > we also could leave the struct and mark it with CODEC_CAP_EXPERIMENTAL
> 
> The code is sprinkled with if(s->msmpeg4_version==1) making all the
> working encoders slower for no good reason.

Given that we never had a working encoder few people will know for sure
if they are correct or not anyway.
Maybe there's a volunteer to replace those if (...) by comments that
say what we know, and what we suspect, needs to be done for v1 and why?