[FFmpeg-cvslog] r24156 - trunk/configure

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Sat, Jul 10, 2010 at 12:15:50PM +0100, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> > WTF? This has not the slightest bit to do with this change.
>> 
>> The change replaced a check for x86_64 with a different check.
>
> Yes, and the x86_64 check was a pathetic way to detect MinGW64

Why is that pathetic?  I thought mingw64 was by definition mingw
running in 64-bit mode.

>> > The change is about avoiding an incorrect
>> > die "ERROR: MinGW runtime version must be >= 3.15."
>> > When compiling a 32 bit binary using mingw-w64 headers.
>> 
>> When compiling a 32-bit binary, "enabled x86_64" should never be
>> true.  The change only makes any sense at all if x86_64 is incorrectly
>> enabled at some point.
>
> No, the issue is that it is _correctly_ _disabled_
>
>> >> >> > -        if ! enabled x86_64; then
>> >> >> > +        if ! check_cpp_condition _mingw.h "defined (__MINGW64_VERSION_MAJOR)"; then
>
> If x86_64 was _correctly_ _disabled_ then the mingw_32_ version check would
> run even on mingw-w_64_, and fail.

OK, now I'm thoroughly confused.  Can you please explain to me 1) what
those version checks are really for, 2) why they fail on mingw64, and
3) how the VFW version check relates to all this.

-- 
M?ns Rullg?rd
mans at mansr.com