[FFmpeg-cvslog] r24143 - in trunk/tests: ref/acodec/adpcm_ima_qt ref/acodec/adpcm_ima_wav ref/acodec/adpcm_ms ref/acodec/adpcm_swf ref/acodec/adpcm_yam ref/acodec/alac ref/acodec/flac ref/acodec/g726 ref/acodec/mp...

[Måns Rullgård]

Alex Converse <alex.converse at gmail.com> writes:

> On Fri, Jul 9, 2010 at 12:06 PM, mru <subversion at mplayerhq.hu> wrote:
>> Author: mru
>> Date: Fri Jul ?9 18:06:05 2010
>> New Revision: 24143
>>
>> Log:
>> tiny_psnr: skip wav headers on input files
>>
>> The byte count printed excludes the header, and offsets are applied
>> after the the headers are skipped.
>>
>> Reference files updated to reflect new output. ?Some stddev/psnr values
>> have changed slightly due to headers no longer being compared.
>>
>
> Does it make more sense to make this an option?

Why would you ever want to calculate the psnr of a wav header?

> Do we care about breaking third party scripts that use tiny_psnr?

IMO we do not.  tiny_psnr lives in the tests/ directory and is
intended primarily for use in our testing.  Anyone using it in their
scripts must have a separate copy installed, and will thus notice this
change.

> What about the case where the first bytes of a file happen to be a wav
> header? Or is that too unlikely to care about?

It checks 8 bytes, so looking like a wav file by random chance seems
unlikely.

-- 
M?ns Rullg?rd
mans at mansr.com