[FFmpeg-cvslog] r24086 - in trunk/libavutil: common.h intmath.h

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Wed, Jul 07, 2010 at 07:27:43PM +0200, mru wrote:
>> 
>> --- trunk/libavutil/common.h	Wed Jul  7 19:27:39 2010	(r24085)
>> +++ trunk/libavutil/common.h	Wed Jul  7 19:27:43 2010	(r24086)
>> @@ -312,3 +308,15 @@ static inline av_const int av_ceil_log2(
>>  #endif /* HAVE_AV_CONFIG_H */
>>  
>>  #endif /* AVUTIL_COMMON_H */
>> +
>> +/*
>> + * The following definitions are outside the multiple inclusion guard
>> + * to ensure they are immediately available in intmath.h.
>> + */
>
> This feels fragile to me.

Why do you think I put a comment there?

> Shouldn't we try to solve this in another way?

The only other option I can think of is to duplicate that lot in
intmath.h, also not pretty.  Do you have a better idea?

-- 
M?ns Rullg?rd
mans at mansr.com