[FFmpeg-cvslog] r21560 - trunk/libavformat/isom.c

reimar subversion
Sat Jan 30 23:05:26 CET 2010


Author: reimar
Date: Sat Jan 30 23:05:26 2010
New Revision: 21560

Log:
Store strings directly in mov_mdhd_language_map instead of using pointers,
which has a up to 200% overhead.
Also allows to use memcpy instead of strcpy.

Modified:
   trunk/libavformat/isom.c

Modified: trunk/libavformat/isom.c
==============================================================================
--- trunk/libavformat/isom.c	Sat Jan 30 22:55:18 2010	(r21559)
+++ trunk/libavformat/isom.c	Sat Jan 30 23:05:26 2010	(r21560)
@@ -244,25 +244,25 @@ const AVCodecTag ff_codec_movsubtitle_ta
 /* cf. QTFileFormat.pdf p253, qtff.pdf p205 */
 /* http://developer.apple.com/documentation/mac/Text/Text-368.html */
 /* deprecated by putting the code as 3*5bit ascii */
-static const char * const mov_mdhd_language_map[] = {
+static const char mov_mdhd_language_map[][4] = {
     /* 0-9 */
     "eng", "fra", "ger", "ita", "dut", "sve", "spa", "dan", "por", "nor",
     "heb", "jpn", "ara", "fin", "gre", "ice", "mlt", "tur", "hr "/*scr*/, "chi"/*ace?*/,
-    "urd", "hin", "tha", "kor", "lit", "pol", "hun", "est", "lav",  NULL,
-    "fo ",  NULL, "rus", "chi",  NULL, "iri", "alb", "ron", "ces", "slk",
+    "urd", "hin", "tha", "kor", "lit", "pol", "hun", "est", "lav",    "",
+    "fo ",    "", "rus", "chi",    "", "iri", "alb", "ron", "ces", "slk",
     "slv", "yid", "sr ", "mac", "bul", "ukr", "bel", "uzb", "kaz", "aze",
     /*?*/
-    "aze", "arm", "geo", "mol", "kir", "tgk", "tuk", "mon",  NULL, "pus",
+    "aze", "arm", "geo", "mol", "kir", "tgk", "tuk", "mon",    "", "pus",
     "kur", "kas", "snd", "tib", "nep", "san", "mar", "ben", "asm", "guj",
-    "pa ", "ori", "mal", "kan", "tam", "tel",  NULL, "bur", "khm", "lao",
+    "pa ", "ori", "mal", "kan", "tam", "tel",    "", "bur", "khm", "lao",
     /*                   roman? arabic? */
     "vie", "ind", "tgl", "may", "may", "amh", "tir", "orm", "som", "swa",
     /*==rundi?*/
-    NULL, "run",  NULL, "mlg", "epo",  NULL,  NULL,  NULL,  NULL,  NULL,
+       "", "run",    "", "mlg", "epo",    "",    "",    "",    "",    "",
     /* 100 */
-    NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL,
-    NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL,
-    NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL,  NULL, "wel", "baq",
+       "",    "",    "",    "",    "",    "",    "",    "",    "",    "",
+       "",    "",    "",    "",    "",    "",    "",    "",    "",    "",
+       "",    "",    "",    "",    "",    "",    "",    "", "wel", "baq",
     "cat", "lat", "que", "grn", "aym", "tat", "uig", "dzo", "jav"
 };
 
@@ -271,8 +271,8 @@ int ff_mov_iso639_to_lang(const char lan
     int i, code = 0;
 
     /* old way, only for QT? */
-    for (i = 0; !mp4 && i < FF_ARRAY_ELEMS(mov_mdhd_language_map); i++) {
-        if (mov_mdhd_language_map[i] && !strcmp(lang, mov_mdhd_language_map[i]))
+    for (i = 0; lang[0] && !mp4 && i < FF_ARRAY_ELEMS(mov_mdhd_language_map); i++) {
+        if (!strcmp(lang, mov_mdhd_language_map[i]))
             return i;
     }
     /* XXX:can we do that in mov too? */
@@ -309,8 +309,8 @@ int ff_mov_lang_to_iso639(unsigned code,
     /* old fashion apple lang code */
     if (code >= FF_ARRAY_ELEMS(mov_mdhd_language_map))
         return 0;
-    if (!mov_mdhd_language_map[code])
+    if (!mov_mdhd_language_map[code][0])
         return 0;
-    strncpy(to, mov_mdhd_language_map[code], 4);
+    memcpy(to, mov_mdhd_language_map[code], 4);
     return 1;
 }



More information about the ffmpeg-cvslog mailing list