[FFmpeg-cvslog] r21226 - in trunk: Makefile common.mak subdir.mak

[Måns Rullgård]

Ramiro Polla <ramiro.polla at gmail.com> writes:

> On Sat, Jan 16, 2010 at 6:47 PM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
>> On Fri, Jan 15, 2010 at 5:26 PM, Reimar D?ffinger
>> <Reimar.Doeffinger at gmx.de> wrote:
>>> On Fri, Jan 15, 2010 at 08:16:28PM +0100, ramiro wrote:
>>>> Author: ramiro
>>>> Date: Fri Jan 15 20:16:28 2010
>>>> New Revision: 21226
>>>>
>>>> Log:
>>>> Get one step closer to world domination.
>>>> Remove "make uninstall".
>>>>
>>>> Modified:
>>>> ? ?trunk/Makefile
>>>> ? ?trunk/common.mak
>>>> ? ?trunk/subdir.mak
>>>>
>>>> Modified: trunk/Makefile
>>>> ==============================================================================
>>>> --- trunk/Makefile ? ?Fri Jan 15 19:50:53 2010 ? ? ? ?(r21225)
>>>> +++ trunk/Makefile ? ?Fri Jan 15 20:16:28 2010 ? ? ? ?(r21226)
>>>> @@ -110,16 +110,8 @@ install-man: $(MANPAGES)
>>>> ? ? ? install -d "$(MANDIR)/man1"
>>>> ? ? ? install -m 644 $(MANPAGES) "$(MANDIR)/man1"
>>>>
>>>> -uninstall: uninstall-progs uninstall-data uninstall-man
>>>> -
>>>> -uninstall-progs:
>>>> - ? ? rm -f $(addprefix "$(BINDIR)/", $(ALLPROGS))
>>>> -
>>>> -uninstall-data:
>>>> - ? ? rm -rf "$(DATADIR)"
>>>> -
>>>> -uninstall-man:
>>>> - ? ? rm -f $(addprefix "$(MANDIR)/man1/",$(ALLMANPAGES))
>>>> +uninstall:
>>>> + ? ? @echo "I'm sorry, Dave. I'm afraid I can't do that"
>>>
>>> I'm all for a joke, but how about at least printing something useful in addition
>>> (if you really want after a sleep 1) like "Actually this way of uninstalling is
>>> just too unreliable, consider using a tool like (whatever Mans mentioned) and
>>> look in .... for files to manually remove").
>>
>> Hmm, already a report on ffmpeg-user. Patch attached with Mans'
>> description. I think we should also list some common package managers
>> (like red hat's, debian's, etc...). I don't know that much about
>> package managers though, so help from users would be welcome here.
>
> I'll apply this updated patch (that also mentions checkinstall) if
> there are no objections.
>
> Index: Makefile
> ===================================================================
> --- Makefile	(revision 21440)
> +++ Makefile	(working copy)
> @@ -111,7 +111,15 @@
>  	install -m 644 $(MANPAGES) "$(MANDIR)/man1"
>  
>  uninstall:
> -	@echo "I'm sorry, Dave. I'm afraid I can't do that"
> +	@echo
> +	@echo "I'm sorry, Dave. I'm afraid I can't do that."
> +	@echo
> +	@echo "The uninstall target is generally a bad idea. It can very easily end"
> +	@echo "up removing too little or, worse, too much. For managing stuff not"
> +	@echo "covered by the system package manager, it is much better to use"
> +	@echo "something like stow[1] or checkinstall[2] instead."
> +	@echo "[1] http://savannah.gnu.org/projects/stow"
> +	@echo "[2] http://www.asic-linux.com.mx/~izto/checkinstall/"
>  
>  testclean:
>  	rm -rf tests/vsynth1 tests/vsynth2 tests/data tests/*~

This belongs in documentation, not in the makefile IMO.

-- 
M?ns Rullg?rd
mans at mansr.com