[FFmpeg-cvslog] r21148 - trunk/configure

[Michael Kostylev]

On Mon Jan 11 22:43:51 2010
M?ns Rullg?rd wrote:

>>> Log:
>>> Check for struct sockaddr_storage. Patch by Martin Storsj?
>>> <$firstname()$firstname,st>.
>>> 
>>> Modified:
>>>    trunk/configure
>>> 
>>> Modified: trunk/configure
>>> ==============================================================================
>>> --- trunk/configure	Mon Jan 11 18:32:40 2010	(r21147)
>>> +++ trunk/configure	Mon Jan 11 18:42:15 2010	(r21148)
>>> @@ -990,6 +990,7 @@ HAVE_LIST="
>>>      soundcard_h
>>>      poll_h
>>>      struct_addrinfo
>>> +    struct_sockaddr_storage
>>>      sys_mman_h
>>>      sys_resource_h
>>>      sys_select_h
>>> @@ -2451,6 +2452,7 @@ texi2html -version > /dev/null 2>&1 && e
>>>  if enabled network; then
>>>      check_type "sys/types.h sys/socket.h" socklen_t
>>>      check_type netdb.h "struct addrinfo"
>>> +    check_type sys/socket.h "struct sockaddr_storage"
>>>      # Prefer arpa/inet.h over winsock2
>>>      if check_header arpa/inet.h ; then
>>>          check_func closesocket
>>
>> The test fails on OpenBSD:
>> check_type sys/socket.h struct sockaddr_storage
>> check_cc
>> BEGIN /usr/src/fate/build/tmp/ffconf.XXXXX...26485.c
>>     1
>>     2   #include <sys/socket.h>
>>     3   struct sockaddr_storage v;
>> END /usr/src/fate/build/tmp/ffconf.XXXXX...26485.c
>> ccache gcc -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DPIC -std=c99 -fomit-frame-pointer -fPIC -c
>> -o /usr/src/fate/build/tmp/ffconf.XXXXX...26485.o /usr/src/fate/build/tmp/ffconf.XXXXX...26485.c
>> In file included from /usr/src/fate/build/tmp/ffconf.XXXXX...26485.c:2:
>> /usr/include/sys/socket.h:152: error: syntax error before "u_int8_t"
>> /usr/include/sys/socket.h:170: error: syntax error before "u_int8_t"
>> /usr/include/sys/socket.h:173: error: syntax error before "u_int64_t"
>>
>> It seems sys/socket.h is completely unusable without sys/types.h,
>> but the latter is not included from the former.
> 
> FUCKING IDIOTS
> 
> The specification for sys/socket.h mentions NO types from sys/types.h.
> 
> If this continues, we may well have to kill BSD support.

I'd simply add --disable-network on FATE.
And I guess the sys/types.h hack can be removed then.

-     check_type "sys/types.h sys/socket.h" socklen_t
+     check_type sys/socket.h socklen_t

Michael