[FFmpeg-cvslog] r22107 - trunk/libavformat/rtpproto.c

[Luca Abeni]

Hi,

[sending this email again, since my previous attempt did not reach the 
mailing list]
On 28/02/10 11:29, Luca Abeni wrote:
> On 28/02/10 04:59, cehoyos wrote:
>> Author: cehoyos
>> Date: Sun Feb 28 04:59:15 2010
>> New Revision: 22107
>>
>> Log:
>> Include rtpdec.h, it contains prototypes for the following functions:
>> rtp_set_remote_url(), rtp_get_local_port(), rtp_get_file_handles()
>>
>> Modified:
>> trunk/libavformat/rtpproto.c
>>
>> Modified: trunk/libavformat/rtpproto.c
>> ==============================================================================
>>
>> --- trunk/libavformat/rtpproto.c Sun Feb 28 04:52:10 2010 (r22106)
>> +++ trunk/libavformat/rtpproto.c Sun Feb 28 04:59:15 2010 (r22107)
>> @@ -26,6 +26,7 @@
>>
>> #include "libavutil/avstring.h"
>> #include "avformat.h"
>> +#include "rtpdec.h"
>
> While this obviously fixes the warning, I think it points out a problem:
> including a demuxer-related file (rtpdec.h) in a protocol-related file
> does not look correct to me.
> Maybe, the correct thing to do is to create an rtpproto.h file, and to
> define those prototypes there. BTW, it seems to me that
> rtp_get_file_handles() is not used anywhere... Maybe it can be removed?


				Luca