[FFmpeg-cvslog] r21850 - in trunk/libavformat: avi.c avienc.c metadata.c metadata.h mp3.c utils.c

[Ronald S. Bultje]

Hi,

On Tue, Feb 23, 2010 at 8:38 PM, James Darnley <james.darnley at gmail.com> wrote:
> On 16 February 2010 17:32, rbultje <subversion at mplayerhq.hu> wrote:
>> Log:
>> Set lavf identification string globally in av_write_header(), rather
>> than inside the muxers. Remove special handling of "encoder" tags from
>> AVI and MP3 muxers.
>
> What are the chances of getting this reverted? ?I ask because my "flac
> tags" patch already writes the LIBAVFORMAT_IDENT string in the
> VorbisComment as the vendor_string. ?This means that the encoder tag
> is redundant. ?I would also argue that it is wrong because libavcodec
> is the encoder.

Can you amend it to not double-write it? Or please discuss on
ffmpeg-devel, the person who wrote this patch might not be on cvslog
(since he does not have a SVN account).

Ronald