[FFmpeg-cvslog] r24988 - in trunk/libavcodec/x86: Makefile dsputil_mmx.c vp3dsp.asm vp3dsp_mmx.c vp3dsp_mmx.h vp3dsp_sse2.c vp3dsp_sse2.h

[Aurelien Jacobs]

On Mon, Aug 30, 2010 at 04:31:19PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Aug 30, 2010 at 4:18 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> > On Mon, Aug 30, 2010 at 06:25:46PM +0200, rbultje wrote:
> >> Author: rbultje
> >> Date: Mon Aug 30 18:25:46 2010
> >> New Revision: 24988
> >>
> >> Log:
> >> Move VP3 IDCT functions from inline ASM to YASM. This fixes part of the VP3/5/6
> >> issues on Win64.
> >
> > It seems to break compilation on os/2:
> > http://fate.ffmpeg.org/x86.os2.444/20100830181933/compile
> 
> Fixed in r24992.
> 
> Having said that, we really shouldn't run fate on exotic systems with
> yasm disabled, that defeats the whole point.

I don't know nothing about OS/2, but maybe yasm don't work OS/2... ?

On the other hand, it is a good thing to have at least one fate machine
without yasm, to detect issues such as the one with this commit (but
this could be on a less exotic system).

Aurel