[FFmpeg-cvslog] r24956 - in trunk/tests: fate2.mak ref/fate/fax-g4 ref/fate/fax-g4s

[Vitor Sessak]

On 08/28/2010 05:47 PM, M?ns Rullg?rd wrote:
> vitor<subversion at mplayerhq.hu>  writes:
>
>    
>> Author: vitor
>> Date: Sat Aug 28 16:45:51 2010
>> New Revision: 24956
>>
>> Log:
>> Remove CCITT fax G4 tests (partial revert of r24954). This test is
>> corrupting memory somehow and segfaulting in the BSDs.
>>
>> Deleted:
>>     trunk/tests/ref/fate/fax-g4
>>     trunk/tests/ref/fate/fax-g4s
>> Modified:
>>     trunk/tests/fate2.mak
>>
>> Modified: trunk/tests/fate2.mak
>> ==============================================================================
>> --- trunk/tests/fate2.mak	Sat Aug 28 16:07:16 2010	(r24955)
>> +++ trunk/tests/fate2.mak	Sat Aug 28 16:45:51 2010	(r24956)
>> @@ -191,8 +191,3 @@ fate-fax-g3: CMD = framecrc -i $(SAMPLES
>>   FATE_TESTS += fate-fax-g3s
>>   fate-fax-g3s: CMD = framecrc -i $(SAMPLES)/CCITT_fax/G31DS.TIF
>>
>> -FATE_TESTS += fate-fax-g4
>> -fate-fax-g4: CMD = framecrc -i $(SAMPLES)/CCITT_fax/G4.TIF
>> -
>> -FATE_TESTS += fate-fax-g4s
>> -fate-fax-g4s: CMD = framecrc -i $(SAMPLES)/CCITT_fax/G4S.TIF
>>      
> Why?  We should fix whatever is going wrong on the BSDs instead.
>    

Because the problem is not BSD specific, but a bug in the decoder code. 
Try the attached patch, the decoder is reading memory it is not supposed 
to. I don't like adding regtests for codecs that are reading invalid 
mem, it would end up making fate all-red for a long time. Others 
problematic codecs can be found in [1].

-Vitor

[1] 
http://wiki.multimedia.cx/index.php?title=FATE_Test_Coverage#Bugs_blocking_some_FATE_tests
-------------- next part --------------
A non-text attachment was scrubbed...
Name: faxbug.diff
Type: text/x-patch
Size: 1154 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100828/ba7cdfa9/attachment.bin>