[FFmpeg-cvslog] r24926 - trunk/libavcodec/x86/vp56dsp.asm

[Måns Rullgård]

"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
>
> On Wed, Aug 25, 2010 at 11:41 AM, mru <subversion at mplayerhq.hu> wrote:
>> Author: mru
>> Date: Wed Aug 25 17:41:11 2010
>> New Revision: 24926
>>
>> Log:
>> VP6: fix vp6_filter_diag4_mmx/sse on 64-bit
>>
>> The stride can be negative and must be sign extended before being
>> used in pointer arithmetic.
>>
>> Modified:
>> ? trunk/libavcodec/x86/vp56dsp.asm
>>
>> Modified: trunk/libavcodec/x86/vp56dsp.asm
>> ==============================================================================
>> --- trunk/libavcodec/x86/vp56dsp.asm ? ?Wed Aug 25 17:32:29 2010 ? ? ? ?(r24925)
>> +++ trunk/libavcodec/x86/vp56dsp.asm ? ?Wed Aug 25 17:41:11 2010 ? ? ? ?(r24926)
>> @@ -127,6 +127,9 @@ cglobal vp6_filter_diag4_%1, 5, 7, %2
>> ? ? sub ? ? ? ? rsp, 8*15
>> ? ? movq ? ? ? ? m6, [pw_64]
>> ?%endif
>> +%ifdef ARCH_X86_64
>> + ? ?movsxd ? ? ? r2, r2d
>> +%endif
>
> This "problem" is biting me in other places too, and I don't like this
> at all. Does anyone have opinions on best way forward from here?
>
> <crazy>
> How about making all SIMD-related int->long?
> </crazy>

Isn't long 32-bit on win64 or something like that?

-- 
M?ns Rullg?rd
mans at mansr.com