[FFmpeg-cvslog] r24909 - in trunk/libavcodec: arm/dsputil_iwmmxt.c dsputil.h h263dec.c ppc/dsputil_ppc.c ppc/mpegvideo_altivec.c x86/dnxhd_mmx.c x86/dsputil_mmx.c x86/dsputilenc_mmx.c x86/h264dsp_mmx.c x86/motion_...

[Måns Rullgård]

Alex Converse <alex.converse at gmail.com> writes:

> On Tue, Aug 24, 2010 at 1:47 PM, mru <subversion at mplayerhq.hu> wrote:
>> Author: mru
>> Date: Tue Aug 24 19:47:05 2010
>> New Revision: 24909
>>
>> Log:
>> Remove global mm_flags variable
>>
>> Modified:
>> ? trunk/libavcodec/arm/dsputil_iwmmxt.c
>> ? trunk/libavcodec/dsputil.h
>> ? trunk/libavcodec/h263dec.c
>> ? trunk/libavcodec/ppc/dsputil_ppc.c
>> ? trunk/libavcodec/ppc/mpegvideo_altivec.c
>> ? trunk/libavcodec/x86/dnxhd_mmx.c
>> ? trunk/libavcodec/x86/dsputil_mmx.c
>> ? trunk/libavcodec/x86/dsputilenc_mmx.c
>> ? trunk/libavcodec/x86/h264dsp_mmx.c
>> ? trunk/libavcodec/x86/motion_est_mmx.c
>> ? trunk/libavcodec/x86/mpegaudiodec_mmx.c
>> ? trunk/libavcodec/x86/mpegvideo_mmx.c
>> ? trunk/libavcodec/x86/snowdsp_mmx.c
>> ? trunk/libavcodec/x86/vc1dsp_mmx.c
>> ? trunk/libavcodec/x86/vp8dsp-init.c
>>
>
> You broke --cpu=i686 and --cpu=pentiumpro

Only for CPUs so old they barely exist.

> Index: configure
> ===================================================================
> --- configure	(revision 24937)
> +++ configure	(working copy)
> @@ -2104,8 +2104,15 @@
>              cpuflags="-march=$cpu"
>              disable cmov
>          ;;
> +        # targets that do support conditional mov (cmov) but not MMX

Just drop that comment.  It's obvious what it is.

> +            cpuflags="-march=$cpu"
> +            disable mmx
> +            enable cmov
> +            enable fast_cmov
> +        ;;
>          # targets that do support conditional mov (cmov)
> -        i686|pentiumpro|pentium[23]|pentium-m|athlon|athlon-tbird|athlon-4|athlon-[mx]p|athlon64|k8|opteron|athlon-fx|core2|amdfam10|barcelona|atom)
> +        pentium[23]|pentium-m|athlon|athlon-tbird|athlon-4|athlon-[mx]p|athlon64|k8|opteron|athlon-fx|core2|amdfam10|barcelona|atom)
>              cpuflags="-march=$cpu"
>              enable cmov
>              enable fast_cmov

OK otherwise.

-- 
M?ns Rullg?rd
mans at mansr.com