[FFmpeg-cvslog] r22937 - in trunk: libavcodec/amrnbdec.c libavcodec/atrac1.c libavcodec/audioconvert.c libavcodec/qcelpdata.h libavcodec/qcelpdec.c libavcodec/ra288.c libavcodec/sipr.c libavcodec/sipr16k.c libavco...

[Ronald S. Bultje]

Hi,

On Mon, Apr 26, 2010 at 4:54 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Apr 26, 2010 at 10:13:00AM -0400, Ronald S. Bultje wrote:
>> On Mon, Apr 26, 2010 at 9:57 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Mon, Apr 26, 2010 at 09:36:41AM -0400, Ronald S. Bultje wrote:
>> >> On Sun, Apr 25, 2010 at 6:04 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >> > On Sun, Apr 25, 2010 at 12:56:18PM -0400, Ronald S. Bultje wrote:
>> >> >> 2010/4/25 M?ns Rullg?rd <mans at mansr.com>:
>> >> >> > "Ronald S. Bultje" <rsbultje at gmail.com> writes:
>> >> >> >> ?static inline av_const int32_t av_clipl_int32(int64_t a)
>> >> >> >> ?{
>> >> >> >> - ? ?if ((a+2147483648) & ~2147483647) return (a>>63) ^ 2147483647;
>> >> >> >> + ? ?if ((a+0x80000000U) & ~INT64_C(0xFFFFFFFF)) return (a>>63) ^ 0x7FFFFFFF;
>> >> >> >> ? ? ?else ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?return a;
>> >> >> >> ?}
>> >> >> >
>> >> >> > I prefer writing the u suffix in lowercase, as that makes it visually
>> >> >> > more distinct from the digits.
>> >> >> >
>> >> >> > Please use UINT64_C to avoid any surprises from bitwise operations on
>> >> >> > signed numbers.
>> >> >>
>> >> >> Both fixed.
>> >> >>
>> >> >> Ronald
>> >> >
>> >> >> ?common.h | ? ?2 +-
>> >> >> ?1 file changed, 1 insertion(+), 1 deletion(-)
>> >> >> 5d9eac3782a574b9d0a506034c872c4605589685 ?clip.patch
>> >> >
>> >> > assuming everyone is done with the bikeshedding, patch ok
>> >>
>> >> Applied.
>> >>
>> >> Would you like me to change decimal->hex for the int16/uint8 clip
>> >> functions as well?
>> >
>> > yes they will look beautifull painted in hex
>>
>> $attached.paint(). (Cosmetics will follow next.)
>>
>> Ronald
>
>> ?common.h | ? ?6 +++---
>> ?1 file changed, 3 insertions(+), 3 deletions(-)
>> a078a9a6ccc27e8c7690a25a3e827c996e95fddf ?clip.patch
>
> ok

Applied.

Ronald