[FFmpeg-cvslog] r22937 - in trunk: libavcodec/amrnbdec.c libavcodec/atrac1.c libavcodec/audioconvert.c libavcodec/qcelpdata.h libavcodec/qcelpdec.c libavcodec/ra288.c libavcodec/sipr.c libavcodec/sipr16k.c libavco...

[Ronald S. Bultje]

Hi,

2010/4/25 M?ns Rullg?rd <mans at mansr.com>:
> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
>> ?static inline av_const int32_t av_clipl_int32(int64_t a)
>> ?{
>> - ? ?if ((a+2147483648) & ~2147483647) return (a>>63) ^ 2147483647;
>> + ? ?if ((a+0x80000000U) & ~INT64_C(0xFFFFFFFF)) return (a>>63) ^ 0x7FFFFFFF;
>> ? ? ?else ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?return a;
>> ?}
>
> I prefer writing the u suffix in lowercase, as that makes it visually
> more distinct from the digits.
>
> Please use UINT64_C to avoid any surprises from bitwise operations on
> signed numbers.

Both fixed.

Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clip.patch
Type: application/octet-stream
Size: 458 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100425/ae9feead/attachment.obj>