[FFmpeg-cvslog] r22770 - trunk/libavutil/attributes.h

[Måns Rullgård]

michael <subversion at mplayerhq.hu> writes:

> Author: michael
> Date: Fri Apr  2 03:03:27 2010
> New Revision: 22770
>
> Log:
> av_builtin_constant_p()

I would prefer calling it simply av_constant_p().  The 'builtin'
qualifier is a gcc thing.  It's not "built in" to anything "av".

> Modified:
>    trunk/libavutil/attributes.h
>
> Modified: trunk/libavutil/attributes.h
> ==============================================================================
> --- trunk/libavutil/attributes.h	Fri Apr  2 00:34:22 2010	(r22769)
> +++ trunk/libavutil/attributes.h	Fri Apr  2 03:03:27 2010	(r22770)
> @@ -104,4 +104,10 @@
>  #endif
>  #endif
>
> +#ifdef __GNUC__
> +#    define av_builtin_constant_p __builtin_constant_p
> +#else
> +#    define av_builtin_constant_p(x) 0
> +#endif

How bad is it if this isn't available?  We should avoid penalising
non-gcc compilers unnecessarily.

-- 
M?ns Rullg?rd
mans at mansr.com