[FFmpeg-cvslog] r22667 - in trunk/libavformat: httpauth.c httpauth.h

[Martin Storsjö]

On Fri, 2 Apr 2010, Ronald S. Bultje wrote:

> On Fri, Apr 2, 2010 at 5:55 PM, Daniel Verkamp <daniel at drv.nu> wrote:
> > On Thu, Mar 25, 2010 at 8:58 AM, mstorsjo <subversion at mplayerhq.hu> wrote:
> >> + ? ?/* Generate a client nonce. */
> >> + ? ?for (i = 0; i < 2; i++)
> >> + ? ? ? ?cnonce_buf[i] = ff_random_get_seed();
> >> + ? ?ff_data_to_hex(cnonce, (const uint8_t*) cnonce_buf, sizeof(cnonce_buf), 1);
> >
> >> + ? ?cnonce[2*sizeof(cnonce_buf)] = 0;
> >
> > GCC warns that this is out of array bounds, and I think it is right:
> > 2*sizeof(cnonce_buf) = 16, but cnonce is only 9 entries long.
> 
> Fixed.

Oops, good catch. Thanks!

// Martin