[FFmpeg-cvslog] r19912 - trunk/libavcodec/dnxhdenc.c

[Reimar Döffinger]

On Sat, Sep 19, 2009 at 12:05:24PM +0200, Reimar D?ffinger wrote:
> On Sat, Sep 19, 2009 at 10:59:57AM +0100, M?ns Rullg?rd wrote:
> > Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > 
> > > On Fri, Sep 18, 2009 at 09:03:05PM +0200, bcoudurier wrote:
> > >> Author: bcoudurier
> > >> Date: Fri Sep 18 21:03:05 2009
> > >> New Revision: 19912
> > >> 
> > >> Log:
> > >> fix uninitialized memory in dnxhd encoder
> > >
> > > Any idea what the remaining issue is? It looks like the encoder produces
> > > one kind of file for all Linux systems, a different but consistent one
> > > for all OSX and FreeBSD systems and yet another one for all Solaris
> > > ones.
> > > CPU architecture seems to not play a role.
> > > valgrind does not report any uninitialized access for me though.
> > 
> > Adding to the mystery, I'm getting this on my x86_64 machine:
> > 
> > --- /home/mru/src/ffmpeg.master/tests/vsynth.regression.ref     2009-09-18 23:40:08.290023048 +0100
> > +++ tests/data/vsynth.regression        2009-09-19 10:57:31.575695936 +0100
> > @@ -164,8 +164,8 @@
> >  stddev:    1.72 PSNR: 43.37 bytes:  7603200/  7603200
> >  0f03af66259a656c16b3dfb4a3519685 *./tests/data/a-dnxhd.dnxhd
> >  30310400 ./tests/data/a-dnxhd.dnxhd
> > -ccdceaf818b898fd58fc15977bab2eeb *./tests/data/dnxhd.vsynth.out.yuv
> > -stddev:    1.68 PSNR: 43.61 bytes:  7603200/  7603200
> > +321cf0d7223bfbb0bd7c431d94ef3867 *./tests/data/dnxhd.vsynth.out.yuv
> > +stddev:   21.37 PSNR: 21.52 bytes:  7603200/  7603200
> >  595fc4e38734521356b60e67b813f0fa *./tests/data/a-svq1.mov
> >  1334367 ./tests/data/a-svq1.mov
> >  9cc35c54b2c77d36bd7e308b393c1f81 *./tests/data/svq1.vsynth.out.yuv
> > 
> > The encoded file is the same as elsewhere, but the decoder is failing.
> 
> Note that it might be the scaler that breaks, I am testing now with some
> other scaling options.

The -mbd rd variant is not affected.
I suspect that the issue is the qsort call, where different
implementations of qsort will lead to different encoded files.