[FFmpeg-cvslog] r19889 - trunk/libavformat/utils.c

Michael Niedermayer michaelni
Fri Sep 18 15:20:27 CEST 2009


On Fri, Sep 18, 2009 at 01:32:08AM -0300, Ramiro Polla wrote:
> On Wed, Sep 16, 2009 at 5:23 PM, michael <subversion at mplayerhq.hu> wrote:
> > Author: michael
> > Date: Wed Sep 16 22:23:04 2009
> > New Revision: 19889
> >
> > Log:
> > Print at debug level the score with which probing succeeded.
> >
> > Modified:
> > ? trunk/libavformat/utils.c
> >
> > Modified: trunk/libavformat/utils.c
> > ==============================================================================
> > --- trunk/libavformat/utils.c ? Wed Sep 16 22:06:48 2009 ? ? ? ?(r19888)
> > +++ trunk/libavformat/utils.c ? Wed Sep 16 22:23:04 2009 ? ? ? ?(r19889)
> > @@ -474,6 +474,8 @@ int av_open_input_file(AVFormatContext *
> > ? ? ? ? ? ? }
> > ? ? ? ? ? ? /* guess file format */
> > ? ? ? ? ? ? fmt = av_probe_input_format2(pd, 1, &score);
> > + ? ? ? ? ? ?if(fmt)
> > + ? ? ? ? ? ? ? ?av_log(*ic_ptr, AV_LOG_DEBUG, "Probe with size=%d detected %s with score=%d\n", probe_size, fmt->name, score);
> > ? ? ? ? }
> > ? ? ? ? av_freep(&pd->buf);
> > ? ? }
> 
> There is no guarantee **ic_ptr will point to a valid address. This is
> what caused the crash in
> https://roundup.ffmpeg.org/roundup/ffmpeg/issue1394 .

should be fixed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090918/aa897f9c/attachment.pgp>



More information about the ffmpeg-cvslog mailing list