[FFmpeg-cvslog] r19905 - in trunk/libavformat: rtsp.c rtsp.h

Diego Biurrun diego
Fri Sep 18 15:17:23 CEST 2009


On Fri, Sep 18, 2009 at 09:15:15AM -0400, Ronald S. Bultje wrote:
> 
> On Fri, Sep 18, 2009 at 5:17 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Thu, Sep 17, 2009 at 11:47:11PM +0200, rbultje wrote:
> >>
> >> --- trunk/libavformat/rtsp.c ?Thu Sep 17 23:35:48 2009 ? ? ? ?(r19904)
> >> +++ trunk/libavformat/rtsp.c ?Thu Sep 17 23:47:11 2009 ? ? ? ?(r19905)
> >> @@ -855,6 +856,10 @@ static void rtsp_send_cmd_async (AVForma
> >> ? ? ? ? ?snprintf(buf1, sizeof(buf1), "Session: %s\r\n", rt->session_id);
> >> ? ? ? ? ?av_strlcat(buf, buf1, sizeof(buf));
> >> ? ? ?}
> >> + ? ?if (rt->auth_b64)
> >> + ? ? ? ?av_strlcatf(buf, sizeof(buf),
> >> + ? ? ? ? ? ? ? ? ? "Authorization: Basic %s\r\n",
> >> + ? ? ? ? ? ? ? ? ? rt->auth_b64);
> >
> > indentation
> 
> The idea is that the " of line 2 aligns with the b (after the "(") of
> line 1, I'd consider that prettier. However, seems I screwed up
> because it's one space too little. Not sure what happened. Is that OK
> or do you have another preference? I will fix once I know that's OK.

The idea is that the function arguments are aligned.  So the answer is
yes.

Diego



More information about the ffmpeg-cvslog mailing list