[FFmpeg-cvslog] r19838 - trunk/libavformat/idcin.c

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Mon, Sep 14, 2009 at 08:53:42PM +0100, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> 
>> > On Mon, Sep 14, 2009 at 05:44:05PM +0200, reimar wrote:
>> >> Author: reimar
>> >> Date: Mon Sep 14 17:44:05 2009
>> >> New Revision: 19838
>> >> 
>> >> Log:
>> >> Check buffer size for idcin check, otherwise false positives are too likely for
>> >> small probe buffer sizes due to 0-padding (see probetest results).
>> >
>> > I just realize that once again the padding does not have to be 0-ed,
>> > that might mean quite a few more tests (e.g. sierravmd.c, mm.c) need to
>> > check the buffer size despite the padding.
>> > Is that intended/what should be done?
>> 
>> Which padding are you talking about?
>
> AVPROBE_PADDING_SIZE for the probe functions

We could require it to be zero.

-- 
M?ns Rullg?rd
mans at mansr.com