[FFmpeg-cvslog] r19742 - trunk/libavutil/internal.h

[Diego Biurrun]

On Fri, Sep 04, 2009 at 01:49:49PM -0300, Ramiro Polla wrote:
> On Thu, Sep 3, 2009 at 1:12 PM, Ramiro Polla<ramiro.polla at gmail.com> wrote:
> > On Thu, Sep 3, 2009 at 12:33 PM, Benoit Fouet<benoit.fouet at free.fr> wrote:
> >> On 2009-09-03 17:27, Ramiro Polla wrote:
> > [...]
> >>> --- a/libavutil/internal.h
> >>> +++ b/libavutil/internal.h
> >>> @@ -249,21 +249,21 @@ if ((y) < (x)) {\
> >>>
> >>> -#define CHECKED_ALLOC(p, size)\
> >>> +#define FF_ALLOC_OR_GOTO(ctx, p, size, label)\
> >>>  {\
> >>>      p = av_malloc(size);\
> >>>      if (p == NULL && (size) != 0) {\
> >>> -        av_log(NULL, AV_LOG_ERROR, "Cannot allocate memory.");\
> >>> -        goto fail;\
> >>> +        av_log(ctx, AV_LOG_ERROR, "Cannot allocate memory.");\
> >>> +        goto label;\
> >>>
> >>
> >> not related to this change, but doesn't this also miss a '\n' ?
> >
> > Yes, it does. Ok to just add it?
> 
> ...
> 
> Trivial patch attached.

> --- libavutil/internal.h	(revision 19757)
> +++ libavutil/internal.h	(working copy)
> @@ -253,7 +253,7 @@
>      p = av_malloc(size);\
>      if (p == NULL && (size) != 0) {\
> -        av_log(NULL, AV_LOG_ERROR, "Cannot allocate memory.");\
> +        av_log(NULL, AV_LOG_ERROR, "Cannot allocate memory.\n");\

I don't think there is a need to send patches for such things, just
commit.

Diego