[FFmpeg-cvslog] r19751 - trunk/libavutil/internal.h

Diego Biurrun diego
Tue Sep 1 18:54:11 CEST 2009


On Tue, Sep 01, 2009 at 05:11:05PM +0100, M?ns Rullg?rd wrote:
> diego <subversion at mplayerhq.hu> writes:
> 
> > -    __asm__ volatile ("umull %1, %0, %2, %3"
> > -                      : "=&r"(r), "=&r"(t) : "r"(a), "r"(ff_inverse[b]));
> > +    __asm__ volatile("umull %1, %0, %2, %3"
> > +                     : "=&r"(r), "=&r"(t) : "r"(a), "r"(ff_inverse[b]));
> 
> Why did you remove that space (and others like it)?  I thought the
> general rule was space after keywords, no space after function names.

Hmm, I considered the inline asm a function call..  Apparently it should
rather be the other way around..

Diego



More information about the ffmpeg-cvslog mailing list