[FFmpeg-cvslog] r20416 - trunk/libavcodec/synth_filter.c

Diego Biurrun diego
Fri Oct 30 19:23:15 CET 2009


On Thu, Oct 29, 2009 at 11:58:59AM +0100, michael wrote:
> 
> Log:
> Change whitespace placement a little to improve readabiliy slightly.
> Thats not an attempt to emulate indent -kr behavior down to the finest
> fineprint, first it would not be worth the work, second it would be less
> readable, third it would  not be K&R but indent -kr then.

Thanks.

I don't disagree with what you write there, just a small note for the
future:

> --- trunk/libavcodec/synth_filter.c	Thu Oct 29 11:46:29 2009	(r20415)
> +++ trunk/libavcodec/synth_filter.c	Thu Oct 29 11:58:59 2009	(r20416)
> @@ -31,26 +31,26 @@ void ff_synth_filter_float(FFTContext *i
>  
>      for (i = 0; i < 16; i++){

K&R has a space between ) and {.

> -        float a= synth_buf2[i   ];
> -        float b= synth_buf2[i+16];
> +        float a= synth_buf2[i     ];
> +        float b= synth_buf2[i + 16];
>          float c= 0;
>          float d= 0;

Consistently placing spaces around = does make things more readable.

Diego



More information about the ffmpeg-cvslog mailing list