[FFmpeg-cvslog] r20249 - trunk/libavcodec/opt.c

[Michael Niedermayer]

On Fri, Oct 16, 2009 at 02:51:11PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Fri, Oct 16, 2009 at 01:46:03PM +0100, M?ns Rullg?rd wrote:
> >> michael <subversion at mplayerhq.hu> writes:
> >> 
> >> > Author: michael
> >> > Date: Fri Oct 16 14:35:49 2009
> >> > New Revision: 20249
> >> >
> >> > Log:
> >> > Very evil missuse of svn to test if AVOption and AVOption2 are compatible.
> >> > If this test triggers anywhere for anyone, revert this commit immedeatly.
> >> > Ill revert this in a day or 2, its just so we know beforehand if the idea
> >> > with the union is doable or not without breaking ABI/API.
> >> 
> >> Revert this immediately.  SVN IS NOT YOUR PLAYGROUND.  It is time you
> >> started abiding by the same rules you expect others to follow.
> >
> > calm down please, and then please explain me what the exact problem is?
> 
> The exact problem is that you allowed yourself to commit something you
> yourself describe as "very evil", with no prior discussion whatsoever.
> Had anyone else done something like this, you'd be jumping up and
> down, screaming to have it reverted.  How do you expect people to
> follow your rules, when you completely ignore them yourself?
> 
> I do not know, nor do I care, what the actual change was.  What I care
> about is the manner in which you did it.

I think you overreact but i dont mind at all reverting this and posting
a patch if you prefer?

PS: ill likely be away from my comp for an hour or 2 soon so it might
take me that amount to revert it if i dont read your reply before

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20091016/e74c1b56/attachment-0001.pgp>