[FFmpeg-cvslog] r20249 - trunk/libavcodec/opt.c

[Michael Niedermayer]

On Fri, Oct 16, 2009 at 01:46:03PM +0100, M?ns Rullg?rd wrote:
> michael <subversion at mplayerhq.hu> writes:
> 
> > Author: michael
> > Date: Fri Oct 16 14:35:49 2009
> > New Revision: 20249
> >
> > Log:
> > Very evil missuse of svn to test if AVOption and AVOption2 are compatible.
> > If this test triggers anywhere for anyone, revert this commit immedeatly.
> > Ill revert this in a day or 2, its just so we know beforehand if the idea
> > with the union is doable or not without breaking ABI/API.
> 
> Revert this immediately.  SVN IS NOT YOUR PLAYGROUND.  It is time you
> started abiding by the same rules you expect others to follow.

calm down please, and then please explain me what the exact problem is?

* Making default_val a char* is something quite nice as many things like
  strings or colors are not easy to represent as double
* changing AVOption differently from what i did to introduce a char* default
  would as far as i can see requires us to bump the major version of all libs
  together, iam trying to avoid this ...
* To know if the union trick works in practice or not, i commited this, and
  as its intended to be reverted anyway i saw no need to discuss this, even
  if the code works we still can decide to go a different path and not use
  it.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20091016/eb1df054/attachment.pgp>