[FFmpeg-cvslog] r20211 - in trunk/libavcodec: dnxhdenc.c dnxhdenc.h

[Reimar Döffinger]

On Mon, Oct 12, 2009 at 04:12:13PM -0700, Baptiste Coudurier wrote:
> On 10/12/2009 9:28 AM, Reimar D?ffinger wrote:
> > On Mon, Oct 12, 2009 at 08:39:24AM -0700, Baptiste Coudurier wrote:
> >> On 10/12/09 7:43 AM, reimar wrote:
> >>> Author: reimar
> >>> Date: Mon Oct 12 16:43:57 2009
> >>> New Revision: 20211
> >>>
> >>> Log:
> >>> Move dnxhdenc to execute2 multithreading API.
> >>> This allows for some simplifications like removing some outer loops
> >>> and gives much better performance for thread_count>   number of idle CPUs.
> >>
> >> I don't remember having approved this. Did I ?
> >
> > Hm, not directly, no.
> > You said that a change to the threading code would be ok if it avoided
> > the additional memory usage, which this variant does.
> > Are you ok with it staying committed while you review it or do you want
> > it reverted?
> 
> Nah, it's ok, keep it in svn.
> Maybe I liked slice_offsets better, but that's bikeshed anyway.

That one is a bit ugly I admit, but it aligned so nicely :-)

> I was thinking that _offsets and _sizes may be redundant, but as you 
> said it can be simplified even more.

I'm not sure, I haven't seen a solution to avoid those (except
recalculating in each thread).
However, I think it might make sense to get rid of the mallocs for them
and instead make them fixed-size parts of the context - we are talking
about less than 1kB RAM here after all.