[FFmpeg-cvslog] r20571 - trunk/libavformat/movenc.c

[Måns Rullgård]

Ramiro Polla <ramiro.polla at gmail.com> writes:

> On Sun, Nov 22, 2009 at 9:36 AM, Diego Biurrun <diego at biurrun.de> wrote:
>> On Sun, Nov 22, 2009 at 12:09:37AM -0200, Ramiro Polla wrote:
>>> On Sun, Nov 22, 2009 at 12:07 AM, jbr <subversion at mplayerhq.hu> wrote:
>>> >
>>> > Log:
>>> > Do not write an extra byte in the iTunes 'hdlr' tag. ?The files on iTMS have an
>>> > extra byte and are not compliant with ISO 14496-12. ?This causes some strict
>>> > demuxers (notably the MPEG-4 ALS reference software) to fail. ?It has been
>>> > confirmed that not writing the extra byte will still allow the generated MP4
>>> > files to work with QuickTime/iTunes/iPod.
>>>
>>> > Approved by Baptiste on IRC.
>>>
>>> I think this comment is better as a reply on -cvslog than on the SVN
>>> log message...
>>
>> So that only people browsing the list by chance see this? ?We should
>> have *more*, not less commit messages like this.
>
> What are the benefits of having this in the SVN commit log?
>
> When going through history it's kind of pointless information to know
> it was approved on IRC. Or do you think most of our commits should
> have "Approved by Michael on ML"?

I, and probably Diego too, thought you were referring to the entire
comment, not just the bit about being approved on IRC.

However, having a record of who approved something is a good idea.
Many projects have adopted the Linux kernel Signed-off-by and similar
tags.

-- 
M?ns Rullg?rd
mans at mansr.com