[FFmpeg-cvslog] r20572 - trunk/libavcodec/rv34.c

[Kostya]

On Sun, Nov 22, 2009 at 12:38:27PM +0100, Michael Niedermayer wrote:
> On Sun, Nov 22, 2009 at 08:48:36AM +0100, kostya wrote:
> > Author: kostya
> > Date: Sun Nov 22 08:48:35 2009
> > New Revision: 20572
> > 
> > Log:
> > Update dimensions in AVCodecContext when RV3/4 frame dimensions change
> > 
> > Modified:
> >    trunk/libavcodec/rv34.c
> > 
> > Modified: trunk/libavcodec/rv34.c
> > ==============================================================================
> > --- trunk/libavcodec/rv34.c	Sun Nov 22 03:07:10 2009	(r20571)
> > +++ trunk/libavcodec/rv34.c	Sun Nov 22 08:48:35 2009	(r20572)
> > @@ -1285,8 +1285,8 @@ static int rv34_decode_slice(RV34DecCont
> >          if(s->width != r->si.width || s->height != r->si.height){
> >              av_log(s->avctx, AV_LOG_DEBUG, "Changing dimensions to %dx%d\n", r->si.width,r->si.height);
> >              MPV_common_end(s);
> > -            s->width  = r->si.width;
> > -            s->height = r->si.height;
> > +            s->width  = s->avctx->width  = r->si.width;
> > +            s->height = s->avctx->height = r->si.height;
> 
> avcodec_set_dimensions()
> and this is not a simplification your code is wrong

I was just following examples from h264..c and rv10.c - they do the same
when picture dimensions change. And I've never thought about it as of
simplification.
 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB