[FFmpeg-cvslog] r20448 - in trunk/libavcodec: aac.c aac.h

[Alex Converse]

On Sat, Nov 21, 2009 at 4:10 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de>wrote:

> On Sat, Nov 21, 2009 at 04:01:09PM -0500, Alex Converse wrote:
> > On Sat, Nov 21, 2009 at 5:24 AM, Carl Eugen Hoyos <cehoyos at ag.or.at>
> wrote:
> >
> > > alexc <subversion <at> mplayerhq.hu> writes:
> > >
> > > > Author: alexc
> > > > Date: Tue Nov  3 23:50:02 2009
> > > > New Revision: 20448
> > > >
> > > > Log:
> > > > Don't lock the channel output configuration based on the first value
> seen
> > > for
> > > > non extradata formats. Instead lock it only after the successful
> decoding
> > > of a
> > > > frame. This fixes issue 999.
> > >
> > > And broke the sample from issue 1562;-(
> > > http://roundup.ffmpeg.org/roundup/ffmpeg/file618/aac-32kHz
> > >
> > >
> > Fixed in revision 20570
>
> Is AAC decoding bit-exact so we could add that sample to FATE?
> After all it seems it was broken several times.
>

AAC decoding is nowhere near bitexact.

This is an example of a broken file. The first frame is corrupt. I run the
conformance suite for AAC fairly regularly but it didn't catch this because
the conformance suite doesn't include broken files.