[FFmpeg-cvslog] r20517 - in trunk: Changelog doc/general.texi libavcodec/Makefile libavcodec/allcodecs.c libavcodec/als_data.h libavcodec/alsdec.c

[Reimar Döffinger]

On Fri, Nov 13, 2009 at 10:43:25PM +0100, Thilo Borgmann wrote:
> Diego Biurrun schrieb:
> > On Wed, Nov 11, 2009 at 11:36:17PM +0100, cehoyos wrote:
> >> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> >> +++ trunk/libavcodec/als_data.h	Wed Nov 11 23:36:17 2009	(r20517)
> >> @@ -0,0 +1,95 @@
> >> +/*
> >> + * ALS header file for common data
> > 
> > What's the point of having this in a header file if it is only used in
> > one place, name alsdec.c?
> 
> I don't remember why exactly we put it into a header and not a .c, but
> separation of these tables makes sense because an upcoming encoder will
> have to share these tables with the decoder - and an encoder is not just
> hypothetical.
> 
> There might also be functions to share among them.

That would make the header a even worse place to put them though, since
then they will end up multiple times in the binary.