[FFmpeg-cvslog] r20502 - in trunk: configure libavcodec/allcodecs.c libavcodec/h263dec.c libavcodec/imgconvert.c libavcodec/vdpau.c libavcodec/vdpau.h libavcodec/vdpau_internal.h libavutil/pixfmt.h

[Jai Menon]

On Wed, Nov 11, 2009 at 09:10:56PM +0000, Carl Eugen Hoyos wrote:
> M?ns Rullg?rd <mans <at> mansr.com> writes:
> 
> > 
> > Jai Menon <jmenon86 <at> gmail.com> writes:
> > 
> > > [...]
> > >
> > > My understanding (based on [1]) is that mpeg4 asp is supported in
> > > packages > 190.32. Shouldn't we use some kind of version checking to
> > > make sure we aren't building against older driver packages. Currently,
> > > building against older libvdpau leads to build errors (as is expected).
> 
> [...]
> 
> > Update the check in configure to test for something that's only in
> > recent enough versions.
> 
> While I am certainly not against such a test (MPlayer's configure tests for the
> definition of VDP_VIDEO_MIXER_FEATURE_HIGH_QUALITY_SCALING_L1), I'd like to note
> that
> 1) There was never a released version of libvdpau that does not support current
> svn (only of binary NVIDIA drivers before libvdpau was released as an
> open-source library that needs - currently proprietary - implementations).

I agree that if we go by the current version, then libvdpau 0.2 would
work. But I still think we shouldn't require users with older driver
packages (and whatever libvdpau is bundled alongwith that) to upgrade
just so that they can build the code without compilation errors. My
personal opinion would be that we disable vdpau support when building
against old packages (and probably display a warning asking users to
upgrade to the newer libvdpau package), since forcing them to upgrade
seems kinda harsh.
Opinions?

-- 
Jai Menon