[FFmpeg-cvslog] r20518 - trunk/ffplay.c

[Baptiste Coudurier]

On 11/11/2009 03:51 PM, Diego Biurrun wrote:
> On Wed, Nov 11, 2009 at 03:47:08PM -0800, Baptiste Coudurier wrote:
>> On 11/11/2009 03:46 PM, diego wrote:
>>>
>>> Log:
>>> Add #include for required header config.h.
>>>
>>> --- trunk/ffplay.c	Wed Nov 11 23:36:17 2009	(r20517)
>>> +++ trunk/ffplay.c	Thu Nov 12 00:46:11 2009	(r20518)
>>> @@ -19,6 +19,7 @@
>>>
>>> +#include "config.h"
>>>   #include<math.h>
>>>   #include<limits.h>
>>
>> Are applications supposed to include "config.h" ?
>
> ffserver.c and ffmpeg.c already do it.  All three use definitions from
> config.h all over the place...

I'm worried since it's supposed to be an example on how to use the 
libraries.

IMHO we should once and for all clean the mess and make the symbols not 
part of the API _invisible_.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org