[FFmpeg-cvslog] r18936 - in trunk/libavcodec: Makefile mlpdsp.c

[Ramiro Polla]

  wrote:
> On Mon, May 25, 2009 at 08:07:36AM -0300, Ramiro Polla wrote:
>> I thought we used these kind of casts all over the place in swscale and 
>> such. Any suggestions on what should be done?
> 
> Uh, no, they are only used for "r" constraints, "m", "g" etc. use
> temporary variables if necessary.

local_var.diff adds this to prologue:
+	8b 44 24 38          	mov    0x38(%esp),%eax
+	89 44 24 04          	mov    %eax,0x4(%esp)

ifdef.diff adds no code but adds ugliness and I haven't been able to 
test with llvm yet.

I still don't really understand what llvm is complaining about, but is 
there a way to make llvm stop complaining without altering the object 
code in gcc? There should be a way to correctly specify this...

Besides, how bad can a cast to the same type be?

Ramiro Polla

-------------- next part --------------
A non-text attachment was scrubbed...
Name: local_var.diff
Type: text/x-patch
Size: 664 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090525/545652cf/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ifdef.diff
Type: text/x-patch
Size: 507 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090525/545652cf/attachment-0001.bin>