[FFmpeg-cvslog] r18743 - in trunk/libavcodec: avcodec.h options.c

[Michael Niedermayer]

On Tue, May 05, 2009 at 11:40:24AM -0700, Baptiste Coudurier wrote:
> Hi Michael,
> 
> On 5/5/2009 11:25 AM, michael wrote:
> > Author: michael
> > Date: Tue May  5 20:25:20 2009
> > New Revision: 18743
> > 
> > Log:
> > Add colorspace fields to AVCodecContext.
> 
> First of all this is very nice, thanks for the work.
> 
> >  
> > +enum AVColorPrimaries{
> > +    AVCOL_PRI_BT709      =1, ///< also ITU-R BT1361 / IEC 61966-2-4 / SMPTE RP177 Annex B
> > +    AVCOL_PRI_UNSPECIFIED=2,
> > +    AVCOL_PRI_BT470M     =4,
> > +    AVCOL_PRI_BT470BG    =5, ///< also ITU-R BT601-6 625 / ITU-R BT1358 625 / ITU-R BT1700 625 PAL & SECAM
> > +    AVCOL_PRI_SMPTE170M  =6, ///< also ITU-R BT601-6 525 / ITU-R BT1358 525 / ITU-R BT1700 NTSC
> > +    AVCOL_PRI_SMPTE240M  =7, ///< functionally identical to above
> > +    AVCOL_PRI_FILM       =8,
> > +    AVCOL_PRI_NB           , ///< Not part of ABI
> > +};
> 
> Question does this map in some way what can be stored in mpeg-2 ?

ive not checked it entry by entry but this should pretty much be
= mpeg2 = mpeg4 = h264


> Is this why we duplicate 6/7 ?

yes



> 
> Wouldn't it be better to use BT601 name directly instead ? I reckon
> people are more familiar with this name and 709 now in HD.

I think ive used what was the first listed in the mpeg spec, ive
no oppinion at all on how to call them but there are 2 BT601 variants
...


> 
> Does h.264 use these values in some way too ?

yes all the specs seem to use the same, possibly with minor additions
in later specs

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090505/75ad2558/attachment-0001.pgp>