[FFmpeg-cvslog] r18258 - trunk/libavcodec/vaapi.h

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Tue, Mar 31, 2009 at 10:27:17AM +0000, Carl Eugen Hoyos wrote:
>> Diego Biurrun <diego <at> biurrun.de> writes:
>> 
>> > > > > Revert Diego's r18249:
>> > > > > Add required va/va.h header, should fix 'make checkheaders'.
>> > > > 
>> > > > This is not a revert, you can now remove that header because
>> > > > the file no longer depends on it.
>> > > 
>> > > Note that "make checkheaders" failed on many supported
>> > > platforms with and without your patch for this header, so it
>> > > never was a "fix".
>> > 
>> > Fixing one header is a fix, no matter how many other headers are broken,
>> > just as fixing one crash is a fix, no matter how many other crasher bugs
>> > remain.
>> 
>> Just to clarify:
>> I believe I'm running a supported platform, and for me "make checkheaders"
>> failed for libavcodec/vaapi.h both with and without your patch.
>> And yes, I believe "fixing" a crash that afterwards still crashes on some
>> supported platforms is _not_ a fix.
>
> Under that logic, no crash fix for FFmpeg is ever a fix, because we
> still have crasher bugs in roundup.  So we need a word with the
> semantics I propose to be useful in the real world.  You can keep "fix"
> to mean what you want it to mean.  For my usage let's employ the word
> fix'.
>
> What I did was a fix' to vaapi.h, period.
>
> This talk of checkheaders is leading people astray.  You can use
>
>   make libavcodec/vaapi.ho
>
> instead.

That failed before, and it failed after your fix' on systems without
the vaapi headers installed, i.e. most.

-- 
M?ns Rullg?rd
mans at mansr.com