[FFmpeg-cvslog] r18043 - trunk/libavutil/x86_cpu.h

[Michael Niedermayer]

On Thu, Mar 19, 2009 at 05:42:11PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
> > On Thu, Mar 19, 2009 at 06:15:37PM +0100, Michael Niedermayer wrote:
> >> On Thu, Mar 19, 2009 at 04:51:53PM +0000, M?ns Rullg?rd wrote:
> >> > michael <subversion at mplayerhq.hu> writes:
> >> > 
> >> > > Author: michael
> >> > > Date: Thu Mar 19 15:49:47 2009
> >> > > New Revision: 18043
> >> > >
> >> > > Log:
> >> > > typedef int x86_reg on non x86
> >> > 
> >> > This is UGLY.
> >> 
> >> at least it is just ugly instead of slow and bloated
> >> 
> >> Feel free to repaint the type as you prefer.
> >
> > IMHO that is not as useful as long as it stays in x86_cpu.h.
> > Might it make sense to rename x86_cpu.h to something like asm.h?

yes


> 
> Why should other arches be punished for x86 shortcomings?

me tries to imagine a cpu being punished by x86_cpu.h


anyway, i leave it entirely to the people with the paint cans
to decide and implement the renaming of x86_reg and x86_cpu.h and
spliting this 1 page of header into 50 files spread over several
directories, one for each cpu. so none of them is mistreated by the
others ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090319/801db8d9/attachment.pgp>