[FFmpeg-cvslog] r28996 - trunk/libswscale/rgb2rgb_template.c

[Michael Niedermayer]

On Thu, Mar 19, 2009 at 09:49:53AM +0100, Reimar D?ffinger wrote:
> On Thu, Mar 19, 2009 at 04:58:02AM +0100, Michael Niedermayer wrote:
> > the correct solution is to
> > typedef x86_reg to int on non x86 and maybe rename x86_reg to native_reg
> 
> I thought so too, but I didn't want to wait for the bikeshed discussions
> about how to name it and where to place it to end before dealing with
> this.

i dont mind but the thought that this quick fix might be forgoten and left
in there scares me.
sws is enough of a mess already, no need to make it worse ...


> And yes, I think native_reg is a good name, any suggestion where we
> should define it?

some common header in libavutil would be ideal


> Should it get a ff_ prefix?

thats a seperate discussion, currently x86_reg does not have one ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090319/85dac04e/attachment.pgp>